PrashanthaTP

Remove unnecessary condition inside create_file_list

1

Why check for length of FROM_DIR ,when we can assign the value in the first place https://github.com/PrashanthaTP/wav2mov/blob/3061ed699e476296a832df4272c14bd7bd7899e0/wav2mov/datasets/create_file_list.py#L9-L17

Why not combine cmd line args(options),hparams,and config

1

Since in many places options,hparams,config parameters are being passed why not put them inside a common container? https://github.com/PrashanthaTP/wav2mov/blob/2a765a1b0e8ce106da2aff25e507e79bdcfe5088/main/main.py#L37 https://github.com/PrashanthaTP/wav2mov/blob/2a765a1b0e8ce106da2aff25e507e79bdcfe5088/main/main.py#L40 https://github.com/PrashanthaTP/wav2mov/blob/2a765a1b0e8ce106da2aff25e507e79bdcfe5088/main/main.py#L43

No lip variation in the generated frames.

2

Sync and sequence discriminator don't seem to learn

Inside `HandleEpollEvent` function, Upon EPOLLOUT, if `EAGAIN/EWOULDBLOCK` occurs, the client fd is being readded to epoll list, but shouldn't it be just modified as done while doing `recv`? EPOLLOUT https://github.com/trungams/http-server/blob/1c171367234d245fa9a5452c86354681bbfe383c/src/http_server.cc#L206-L207...