Pierrick Brun
Pierrick Brun
@legalsylvain Ok done ! Thanks for the review
> Is this a backport of v13 functionality? I did not know v13 included this. So this is not a backport. This module allows you to send an e-mail to...
I "fixed" the textinput You can see the failed sent mails in Settings -> Technical -> Email -> Emails (you need to be in debug mode) I'll change the button...
@legalsylvain I've addressed the problems you saw and added tests
@legalsylvain @quentinDupont I think this is in good shape now. I had trouble applying good CSS to the PDF generated by the backend, but in the end I got it...
> @PierrickBrun Could you explain why the `force=True` option is used by default when the mail is sent, and when the `create_from_ui()` with `force=False` is used? I'm worried the session...
Hi @flotho , done. I quickly tested it and it looks like nothing's been broken in the process
@sebastienbeau I had a problem with the order of inheritance so I splited the tools.js file. (The problem did not appear in debug=assets mode)
@simahawk You're right I've renamed the module. Thanks for the review, I've made the changes, the tests still do not pass, I will need to look into it again to...
Also, I've used the same strategy as base_jsonifier to rename the module without breaking the installed databases so there is now and empty module inheriting the not empty one