Filip Brzek
Filip Brzek
So, I've hit a similar issue, code I've used to reproduce, blue-marble with robin projection ```python from mpl_toolkits.basemap import Basemap import matplotlib.pyplot as plt m = Basemap(projection="robin", lon_0=0, resolution=None) m.bluemarble()...
> Do you have the full traceback that you get when using matplotlib 3.5.x? It's a silent failure, the plot is generated but is completely empty except for an outline....
@molinav Thanks for the investigation, I'm not that familiar with the internals of Basemap. Good to know the image is still properly transformed, and just a matter of explicitly adding...
> @Lucretia, expanded testing is something we are pushing for as well. > > PR #71 holds the patch to resolve the segfaults. after re-compiling ROCR-Runtime with mentioned PR clinfo...
That could be done with the ruff pyupgrade rule https://docs.astral.sh/ruff/rules/non-pep604-annotation/, and it would also replace `Optional[X]` with `X | None`. You should probably also update https://github.com/tinygrad/tinygrad/blob/master/setup.py#L26 with `python>=3.10`
IIRC, it could work in python3.7+ codebase, at the cost of adding at the top of modules (that use that new syntax), the following snippet: ``` from __future__ import annotations...
@loriab can I request a re-review?
The duplication of excludes on `ruff.toml` and `.pre-commit` is because when run through `pre-commit` ruff will get an explicit file list, which overrides exclude.
@loriab any thoughts on how we want to proceed with "ruffication" of psi code-base?