pfoerd

Results 12 comments of pfoerd

@hcoles , do you have time for some feedback on this? Thanks!

Hi. If I understand the question correctly this could benefit from the feature request I made some times ago: https://github.com/TNG/ArchUnit/issues/662 . maybe it makes sense to look at both topics...

@arnaudgiuliani could you please have a look on this regression? Would be great if it made it in 3.2.1 as it currently prevents us from using activityRetainedScope.

@arnaudgiuliani i think this could be solved by simply moving the `val scope = getKoinScope()` **into** the factory producer block of `viewModels` calls in [FragmentVM.kt](https://github.com/InsertKoinIO/koin/blob/main/android/koin-android/src/main/java/org/koin/androidx/viewmodel/ext/android/FragmentVM.kt), [FragmentStateVM.kt](https://github.com/InsertKoinIO/koin/blob/main/android/koin-android/src/main/java/org/koin/androidx/viewmodel/ext/android/FragmentStateVM.kt) and [FragmentSharedStateVM.kt](https://github.com/InsertKoinIO/koin/blob/main/android/koin-android/src/main/java/org/koin/androidx/viewmodel/ext/android/FragmentSharedStateVM.kt) extensions. This...

I just wanted to open a similar feature request :) . We would really like to see this DSL marker support too as this would make all the "deprecated" functions...

Likely a duplicate of https://github.com/InsertKoinIO/koin/issues/1356

@arnaudgiuliani could you please re-open this one. I think it is still on on the roadmap for 3.3.0, isn't it?

@szpak what do you think about this addition?

@szpak do you have any feedback on this? This blocks us from integrating history support in our CI pipeline as history file handling depends on whether this will be fixed...