Peter Chang comments

Results 9 comments of


                                            Peter Chang

Update fundamental constants with 2019 redefinition by BIPM

Elementary charge and speed of light are used too in several places in `SI` and `NonSI` classes.

macOS dmg comments

There are two ways to open a Nexus file: 1. Use the``loadTree()`` method from ``HDF5Loader`` or ``NexusHDF5Loader`` in ``ukac.diamond.scisoft.analysis``. This loads the entire tree. 2. Create an ``org.eclipse.dawnsci.nexus.NexusFile`` instance via...

macOS dmg comments

HDF5 is like a file system inside a file with groups acting like directories. Read the fine Nexus [user manual](http://download.nexusformat.org/doc/html/user_manual.html)

There should be a speed test showing the issue (if any) between compiler optimization and January

I think any benchmark should use JMH. Can you refactor to do that and place it in separate fragment?

Java 8

Thanks for the rebase. Any reason why some classpath files are deleted and others not updated?

January should use the intel instructions better

The ``ContiguousIterator`` class used in the simplest case. Is there any reason why the Hotspot JVM cannot dynamically optimise this case - it is a while-loop?

Elements in output compound datasets not reset

I have merged the (partial) fix in #186 so please rebase your PR #184 on master. A complete fix for other methods will be tracked by this issue.

Gotcha: hasNext() modifies state

Yes, `IndexIterator` was unwisely called an iterator but does not behave like `Iterator`. As you guessed correctly, it is for performance to avoid boxing and extra calls (for access to...

Gotcha: hasNext() modifies state

Renaming the classes would avoid future confusion so there would be no expectations on how it works. As you note, these 'iterators' do not offer the contents of the datasets...