Paul Rashidi comments

Results 10 comments of


                                            Paul Rashidi

Use plugin in multi module project

I've got a rather large revamp of the plugin dependency logic at https://github.com/paulrashidi/play-services-plugins/tree/refactor_dep_checking It should support multi-module use although you should only really need it for your APK modules. If...

run_perf_tests.py ShellCommandUnresponsiveException

Is it possible Android Studio or something else on your system is attempting to connect to the same device via ADB?

Step 7. Can't open script run_perf_tests.py on Windows

Thanks. if you qualify run_perf_tests.py as ".\run_perf_tests.py" does it work then? I thought we tested this.

Step 7. Can't open script run_perf_tests.py on Windows

Thanks, it would seem you have to fully qualify the script's location then. That would be the preferred solution since it would keep the source in the repo instead of...

Step 7. Can't open script run_perf_tests.py on Windows

I'll update it in the next day or two.

Step 1 should have users verify ADB is on PATH

PATH=%PATH%;%ANDROID_HOME%/platform-tools/ Also, Step5 doesn't work on Windows and users should be directed to %ANDROID_HOME%/tools/monitor & or the newest versions of systrace.

Reuse of the ViewHolder class name

I made this suggestion to Arthur in the office the other day. I was referencing snippets of the sample when writing something up and the reuse of the ViewHolder class...

Don't share data array between instances.

@devnook Please let me know if you approve.

Remove unused import.

Trevor, he updated his github email. How do we re-trigger the check?

OutOfMemory Issue in the sample app sometimes causes the TestListener not to execute methods

Log to external storage directory instead.