Patrick Geselbracht

Results 40 comments of Patrick Geselbracht

It seems like we are getting a lot closer‽ The PR has been merged! I wasn’t able to test the changes just yet but will soon.

# Before changes ![device-2018-10-16-121449](https://user-images.githubusercontent.com/9012887/47011259-c13ed500-d141-11e8-98a3-cf2ace907477.png) # After all changes ![device-2018-10-16-122024](https://user-images.githubusercontent.com/9012887/47011260-c13ed500-d141-11e8-81b0-eddbc891f002.png)

Might make sense, yes. Should I supply a different pull request or update this one here?

Sure thing! I’ll try to do that today, otherwise until the end of the week.

What’s your opinion regarding `api` VS `implementation` for the dependencies?

Did you select only a subset of `ThemeUtils` at the time? `ThemeEnforcement`—as it is now called—is quite a bit bigger: https://github.com/material-components/material-components-android/blob/master/lib/java/com/google/android/material/internal/ThemeEnforcement.java

It is public, but the `@RestrictTo(LIBRARY_GROUP)` leads to nasty LINT warnings, telling you that >`ThemeEnforcement` can only be called from within the same library group (`groupId=com.android.support`) Your call. :)

https://github.com/opacapp/multiline-collapsingtoolbar/blob/7d39e72eb845def588054b5e9549d60ff04b5b17/multiline-collapsingtoolbar/src/main/java/net/opacapp/multilinecollapsingtoolbar/CollapsingToolbarLayout.java#L519 This line already has the same problem. `ViewGroupUtils` is library-private to the `CoordinatorLayout` library.

For Android 9, this will become problematic—although we’ll probably see a wide-spread usage of Android Pie no earlier than 2021. 🔮 https://developer.android.com/about/versions/pie/restrictions-non-sdk-interfaces

Those are two different settings, I think. See https://github.com/ImageOptim/ImageOptim/issues/133#issuecomment-1892659853 where another user had the same issue, but also the original post of that issue. The missing translation (still missing in...