Pascal Sommer
Pascal Sommer
Thanks for working on this! I agree that the `codegen_info` struct is not really necessary for the comment handling. However I'm not sure how we can handle the different imports...
Hi, I would like to call attention to another way in which this would be relevant for raster backends. I believe issue #283 might be caused by this. When plotting...
It seems like this is related to #128, specifically the fact that plotters tries to draw the lines at integer coordinates but when the backend supports float coordinates then we...
hmm, [circleci fails with `error 'process' is not defined`](https://app.circleci.com/pipelines/github/200ok-ch/organice/1721/workflows/9278e0e9-0086-4841-a65e-b41359c82419/jobs/3641/parallel-runs/0/steps/0-106)... But I noticed that the code is already using the `process` object in `SyncServiceSignIn`, so does anyone know why this fails...
Ah I see, we need to tell eslint that the `process` global exists: https://eslint.org/docs/user-guide/configuring/language-options#specifying-globals Instead of adding the `/* global process */` comment everywhere, would it make more sense to...
I was also wondering what would happen for a subdirectory that contains the string 'files', see this snippet in [`renderFileBrowserBackButton()`](https://github.com/200ok-ch/organice/blob/47f2ccbe34b72900765b3ab9d7bd5ba4ee81bd60/src/components/HeaderBar/index.js#L56): ```js const fileParts = window.location.href.split('/').map((e) => decodeURIComponent(e)); if (_.includes(fileParts, 'files'))...
ah, looks like I missed something, I'll check it out tomorrow
In my original version of the PR I made the mistake of returning an error irrespective of whether or not any of the arguments contained any references, should be fixed...
I just thought of a potential problem: do you think anyone would rename their result type and have a command returning `MyResult`? This currently wouldn't work with this PR
> ```rust > type Result = std::result::Result; > ``` this wouldn't be a problem since we only check if the type is called `Result`, and that's about all we really...