Anton Cherniavskyi
Anton Cherniavskyi
@msf-caesar Why do you think that displaying marks outside is an expected behavior? For me it seems that marks should be inside the track and it should be the default...
@iamkun None of timezone tests is broken, what test do you want me to add? Do you want to simulate `Date { NaN }` behavior or what?
@iamkun Could you please review it?
I faced the same issue, on iOS everything is good, but on Android I got `null` and `Invalid Date`. Maybe it is somehow related to https://github.com/facebook/react-native/issues/28097. Have you found a...
Hi, @weihe8892. You can use `updateLocale` plugin (https://day.js.org/docs/en/customization/customization) to achieve the expected behavior: ``` dayjs.updateLocale('en', { monthsShort: ['JAN', 'FEB', 'MAR', 'APR', 'MAY', 'JUN', 'JUL', 'AUG', 'SEP', 'OCT', 'NOV', 'DEC'], })...
@iamkun I think the problem is in `CustomParseFormat` plugin. It determines afternoon by such condition https://github.com/iamkun/dayjs/blob/dev/src/plugin/customParseFormat/index.js#L55 (`i > 12`), but `meridiem` method of locale returns `12` for afternoon (https://github.com/iamkun/dayjs/blob/dev/src/locale/ja.js#L24), so...
What is needed for this PR to be merged?
@jsh1400 I think it is better to use `AriaRole` type from React to support semantic naming. Will you be able to update PR?
@zombieJ What do you think about passing `aria-required` (maybe even all aria- attributes) to internal `Input` component that currently holds all accessibility attributes (https://github.com/react-component/select/blob/master/src/SelectInput/Input.tsx#L179) instead of provided approach? The same...