Padarn Wilson
Padarn Wilson
Sorry I only have a comment on the last part here. Isn't this approach the same as https://www.math.mcgill.ca/dstephens/PSMMA/Articles/HIrano-Imbens-2004.pdf And also implemented in https://github.com/cran/causaldrf/blob/master/R/hi_est.R Maybe I'm missing something?
The Hirano Imbens paper is not very new... but I will admit I hadn't connected the dots until I read your material. I'm sure new chapters would be popular :-)
Hey @HTenkanen. Yeah certainly have some interest.. but might take me a bit of time to get going. Will have a go at this over the next week. Thanks.
I made a first pass at this in a new MR: https://github.com/robscott/kube-capacity/pull/37.. I don't like the way I've done it, but thought I'd raise the MR to open discussion first.
Hey @pgmikhael, thanks for looking at this. > Beyond that, the fix in master also seems to always return True based on the name of the parent class as long...
Hmm I don't disagree with the requirements, but I'm not super clear on which of them is violated now?
No worries :-) Maybe you could update the test cases if you think that would make it more clear?
This looks really cool. Maybe an example of its use (to give people some idea of where it best applies) would also be nice?
Thanks for your reply. Yeah I missed how this was working sorry. I think probably you can ignore my comments. On Thu, 29 Sep 2022, 1:11 am AlexDuvalinho, ***@***.***> wrote:...
I'll try review again now that I understand, but we should at least add some tests? On Thu, 29 Sep 2022, 6:25 pm AlexDuvalinho, ***@***.***> wrote: > Ok no worries....