Zixuan Li

Results 238 comments of Zixuan Li

Thanks for the report! Currently, muting bot users is not supported. We might implement this in the future. Linking to this comment for backlogging purposes https://github.com/zulip/zulip/pull/16915#issuecomment-808875744.

The above mentioned issue with the validator is fixed in [18a055124a2212e13c97bc1a83cc36b4e8104a97](https://github.com/typeddjango/django-stubs/commit/18a055124a2212e13c97bc1a83cc36b4e8104a97), along with the implementation of `_StrPromise` in django-stubs.

I'm feeling that rate limiting refactoring can be done in a separate PR. We might probably remove `rate_limit` and add a `should_rate_limit` helper. For each view we should know exactly...

Oops, this is accidentally closed by an empty push.

**update** 1946 -> 1892 I have refactored the `render_markdown` function and reduces approximately 50 errors caused by the untyped additional properties added to the message object. It has passed mypy...

**update** 1907 (rebased to master) -> 1889 I have refactored the functions related to `render_incoming_message` to make sure that the additional properties brought by `render_markdown` are now referred via `rendered_message`...

Because this PR is going to be huge and it is unlikely to be completed without running into merge conflicts, perhaps we can start reviewing & merging part of it...

**update** This brings errors down to 1887 (including new errors introduced after rebasing) Created #18917 for markdown-related changes. This is a large PR that has refactored all references to attributes...

**update** The number of errors goes down to 1556 I have fixed most of the errors in `zerver/models.py` by switching to types provided by the stubs plugin, but the provision...

Yes, it works on my machine (wsl, Ubuntu 20.04)