PG
PG
Hello @Damon3499 , Please make sure to upload the correct firmware on device! So, SPIRAM supported firmware to device which has really external PSRAM (M5Core2 for example), and simple non-SPIRAM...
> Interesting. What API should we use for decoder to rotate an image(lv_draw_buf_t * decoded)? Well, I think we should not use LVGL to rotate an image (if it's stored...
> If I understand correctly, this PR introduces capability to rotate JPEG image as instructed. So the better test case would be a 180 rotated logo . Seeing the image...
The actual code is OK (for me), there was only 1 suggestion: have different input JPEG files with different rotations, but only 1 reference image. See: https://github.com/lvgl/lvgl/pull/5263#issuecomment-1900056348 But I think...
> > Can you please add also 1 test: > > show a frame of a [sprite/texture atlas](https://en.wikipedia.org/wiki/Texture_atlas), and rotate it. > > Well, I haven't realized it so far,...
Hello! Yes, the **Split JPEG** feature is removed in LVGL v9, because TJPGD decoder is now used in **partial decoding mode**. It means, that part of the JPEG image can...
Please enable LVGL logging: `LV_USE_LOG` ... and then after `lv_init()` register print: `lv_log_register_print_cb()` (or enable `LV_LOG_PRINTF`). Let's see whether there are error or warning log messages.
Great, thanks to changing base to `master` branch, now only 1 file is changed, that's better to review. I'm not familiar with cmake, sorry, I will skip reviewing this change.
Hello @kisvegabor , 1. I also support reviewing PRs by more devs: allow merging after at least 2 reviewer approved: 1 approver should be in the group "maintainer"; so PRs...
Hello! Thank you for the fast PR reviews, that is also **important** to have fluid work on a project. Just one suggestion regarding PR reviews: when there are feedbacks (and...