ouyangjinting

Results 19 comments of ouyangjinting

I have a look CI test and I do not found SQLite's version information. It may not be able to test fot the SQLite‘s returning caluse feature and maybe need...

> If I understand it well, CI is running in Docker image based on Debian 11 and installing Sqlite3 using system package. > > https://packages.debian.org/bullseye/sqlite3 > > Currently it is...

This is a good feature. If it be merged main, I will try to use it instead of [goldiloader](https://github.com/salsify/goldiloader) gem. But this seems to break [`ActiveRecord::Associations::Preloader::Branch` feature](https://github.com/rails/rails/pull/41596), maybe should to...

@yahonda I re-checked and updated the commit. Can you help to re-review? thank you! I will add returning statement ability for mariadb if this PR can be merged

![image](https://github.com/puma/puma/assets/33079237/ae13d938-adcb-4270-93b2-60c7d17d1ba1) It's normal for me to test locally. The test failed here, [just because of the timeout](https://github.com/puma/puma/actions/runs/9513278045/job/26223048292?pr=3306#step:8:879), it should be ignored.

@ka8725 The actual scenario is as follows: ```shell git checkout -b feat main rails generate model Feat name:string rails db:migrate # create feats table rails runner 'Feat.create(name: :test)' git add...

@ka8725 Thank for you reply. the [migration_data](https://github.com/ka8725/migration_data) is good. But it maybe not handle all scenario, because the some data is generated during manual operation. I also think import that...

@ka8725 Sorry. I just saw this comment today. I'm a little confused that users table has always existed, why the data is lost? Maybe I didn't understand the above example,...

@ka8725 I think the solution may be too complex, maybe it's better to simply give a warm prompt and ask whether to continue rollback. What do you think?

The lint check failed, but it doesn't seem to be caused by this PR change.