Osman A. Malik
Osman A. Malik
@JeanKossaifi Is there anything additional I can do with this PR before it can be merged?
> Thanks @OsmanMalik! It looks like the tests are failing Thanks @JeanKossaifi for pointing that out. I have fixed the issue now and it looks like all the tests are...
@JeanKossaifi Is there anything additional I can do before this can be merged?
> nor thing is perhaps we want to split the tr into two files, one for each main algorithm but no strong opinion! > Happy to merge! @JeanKossaifi : Are...
> Yes exactly! @JeanKossaifi : I've split up `_tr.py` into two files `_tr_svd.py` and `_tr_als.py`. I split the pytest scripts in a similar fashion. The failing test for numpy 3.11...
chaoyihu is right about what the issues is here. I'll elaborate a bit further. The issue is not with the choice of rank, but rather the choice of number of...
> @OsmanMalik thanks for the comment! Could you elaborate on the issue with the randomized parafac? Would be awesome if you are able to add a fix! :) @JeanKossaifi Suppose...