oscar-pepper

#1217 shows how this BlockCache trait is implemented into the #1184 sync engine

Hi @str4d I've made the requested changes and it's ready for review again

> Reviewed as of [7301c0c](https://github.com/zcash/librustzcash/commit/7301c0c76e8dddd965b4705097b7a97144aebe9b). Hi @str4d, thanks for the review, I have replied to and made all requested changes except for adding `&mut` which we should discuss if its...

> If we add the ability to get a transaction record's fee, that could be worth saving as an optional value to avoid needing to re-fetch every time we reload...

the root cause of this is because: 1. sapling send-to-self is marked as change 2. fees in do_list_txsummaries are calculated by a difference between value spent and value outgoing/returned i...

> I believe that the [mine_to_transparent_and_shield](https://github.com/zingolabs/zingolib/blob/f634e0049c4fa31fa8d324df042a9fc830d8bd9d/zingocli/tests/integration_tests.rs#L668) test fails because we have not finished implementing zip317. When we do, this test which should be paying: > > 103*5_000 zats for its...

i am planning on fixing this issue shortly while getting familiar with our new benchmarking framework

hi @AlwaysCompile sorry you didnt receive a reply earlier. Although there is some entanglement that we aim to cleanly separate soon, the commands are written for zingo-cli and therefore print...

NAck: comments in codeshare for discussion

I think we should close this issue because its actually been fixed 😄 sending to sapling address will prioritise a spendable sapling note and, if available, create a sapling change...