Results 24 issues of Tom J Wilson

Currently in PSF photometry routines (`BasicPSFPhotometry` etc.) the actual fitting routine (`LevMarLSQFitter` by default) only works with unit weights, as there is no option to pass any uncertainties -- or...

psf

I have a super barebones PR (#739) in which I looked at adding something like this previously, but with the updates to astropy's uncertainty handling subsequently (and me having less...

psf

Pretty lofty goal, but it seems we're not taking full advantage of the `EPSFStar` vs `LinkedEPSFStar` framework only allowing for fitting of a single image to sources at once. With...

psf

Currently both `EPSFModel` and `EPSFBuilder` carry the keyword `shift_val`, which is likely unnecessary. `EPSFModel` carries it around for one instance in `EPSFBuilder` where it is passed to a function --...

psf

At present, in `EPSFBuilder`, when calculating star residual samplings and sigma clipping multiple samplings to find the robust residual for a given grid point -- used to update the interpolation...

psf
epsf

Currently `fitshape` is a required input into PSF fitting routines like `BasicPSFPhotometry`. It might be good if this could be relaxed to allow for a `None` parameter, for example, which...

psf

`FittableImageModel` has a wrapper for varying PSFs in `GriddablePSFModel`. It would be good if there were other options available in 2D interpolation form -- primarily one for `EPSFModel`, to match...

psf

Unlike `FittableImageModel`, `GriddablePSFModel` doesn't accept 2D oversampling (in the form of an `(x, y)` tuple). Presumably this should be extended to match the parameters accepted by the base class? It...

psf

Any model fit in PSF photometry, passed through ``image = subtract_psf(image, self.psf_model, param_table, subshape=self.fitshape)`` will only have its x and y coordinates and flux updated. ``subtract_psf`` -- used to create...

psf

In ``BasicPSFPhotometry`` and all subclasses ``_define_fit_param_names`` and ``_get_uncertainties`` control the names of the parameters, which are used to generate the ``Table`` instance returned, in which the input values, fit values,...

psf