Tom J Wilson
Tom J Wilson
As I recall users don't actually get access to `fit_info`, do they? If I'm remembering right, this should come out of the `self.fitter` call in `nstars`, at which point we...
Thanks @eteq and @marthaboyer for proofs! I've made most of these changes without comment as they're good suggestions, but I've replied to a few inline comments for further question. With...
Hi @marthaboyer and @eteq - as per a conversation I had offline with @eteq I've pushed the changes I made in response to the comments that were straightforward, but have...
I don't quite see what this would achieve from a cursory glance. ``EPSFFitter`` is _passed_ an ``astropy.modeling.fitting.Fitter`` which does the actual heavy lifting of the determination of coordinates and flux...
Appears I completely forgot to actually reply to this thread when I was assigned this issue to investigate way back, sorry! I actually did run some profiling -- at least...
Ah thanks, I forgot those were astropy functions. Running a quick profile on those two as well: `extract_array` (21.5% x2 of `subtract_psf`): 12% `isscalar(shape)` check 2.5% `isscalar(position)` check 2% `extracted_array...
Thanks for the summary, @eteq. I have started looking into this in more quantitative detail, using @larrybradley's notebook as the foundation. So far I have extended my parameter space to...
(See the bottom of this long post for questions I would like clarifications to; everything before that is mostly context, details, and record keeping) My test suite now is a...
After a quick chat to @eteq it appears this is a case of missing history of the code project resulting in some unforeseen bugs that got past review. I reduced...
While not strictly necessary, and only tangentially related to the above (hence the separate comment), this could also be a good time to consider more stringent checks on `shift_val` and...