Omnia Ibrahim

Results 72 comments of Omnia Ibrahim

## Data Manipulation (Queries) | Feature | P | S | M | | --- | --- | --- | --- | |[INSERT](http://docs.datastax.com/en/cql/3.3/cql/cql_reference/cqlInsert.html)| | | | |[UPDATE](http://docs.datastax.com/en/cql/3.3/cql/cql_reference/cqlUpdate.html)| | | |...

@mimaison, @tombentley can one of you please have a look into this PR? Thanks

> The `MirrorMakerConfigTest` tests the config part, but there's nothing that proves that the configured ForwardingAdmin is actually used when creating topics, ACLs etc. That might not be difficult to...

> > The `MirrorMakerConfigTest` tests the config part, but there's nothing that proves that the configured ForwardingAdmin is actually used when creating topics, ACLs etc. That might not be difficult...

> Thanks for the updates @OmniaGM. There's a test failure: > > ``` > org.apache.kafka.common.KafkaException: The constructor of org.apache.kafka.clients.admin.ForwardingAdmin threw an exception > at app//org.apache.kafka.common.utils.Utils.newParameterizedInstance(Utils.java:466) > at app//org.apache.kafka.connect.mirror.MirrorClientConfig.forwardingAdmin(MirrorClientConfig.java:81) > at...

> @OmniaGM You've been active recently with MirrorMaker 2 and seem quite familiar with it. Would you be willing to give this a review? I'd love it if someone could...

Can we also add an integration test for EOS in MM2 as well? > Hi @OmniaGM -- good questions! Due to [KAFKA-10586](https://issues.apache.org/jira/browse/KAFKA-10586), exactly-once isn't supported when running Mirror Maker 2...

> Thanks @OmniaGM, good idea. I've updated the README and added an integration test that verifies that MM2 can still run with exactly-once support enabled. > > I should note...

> @OmniaGM I see you pushed updates a few times in the past few days. There's nothing wrong with that. Just in case you're pushing to rerun the tests, you...

@mimaison Mirror tests are now okay, the pipeline is failing because of `org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated` which isn't related to this pr.