Ömer Furkan İşleyen

Results 18 comments of Ömer Furkan İşleyen

Why do you use camel case? In Python, the convention is snake case.

You can look at: https://github.com/p4kl0nc4t/kyros

@bschnurr When I use Numpy style docstring, it is shown beautifully, like: ![docstring-numpy](https://user-images.githubusercontent.com/54645034/162836569-ef3325b7-5843-4aea-a305-60c6e87cd3d3.png) But, this is not the case with Sphinx style docstring: ![docstring-sphinx](https://user-images.githubusercontent.com/54645034/162836640-dcf7c821-82c3-4128-b426-6f6c10ba6e0f.png)

> R you requesting something like this? > > ``` > This is a Sphinx Stype Docstring > > :param a: variable 1 > :type a: int > :return: a...

Could you share the `activate.bat` file?

Hi @devanshbatham, will you review this PR? It's been 3 months since the creation of the PR 🙂.

@uranusjr said the following about the `activate.bat` file in Discord: ![resim](https://user-images.githubusercontent.com/54645034/189501274-9391eb67-ad4a-4e92-a0cd-d5bbb3d8f35d.png)

I think we now don't have to change the character code page to 65001 in [_get_test_lines](https://github.com/pypa/virtualenv/blob/main/tests/unit/activation/test_batch.py#L23-L25) function. We can replace this: ```py def _get_test_lines(self, activate_script): # for BATCH utf-8 support...

> I think we now don't have to change the character code page to 65001 in [_get_test_lines](https://github.com/pypa/virtualenv/blob/main/tests/unit/activation/test_batch.py#L23-L25) function. > > We can replace this: > > ```python > def _get_test_lines(self,...

I think we should use `utf-8` in windows not `ascii` to test this Unicode support, so I made these changes in the last [commit](https://github.com/pypa/virtualenv/pull/2416/commits/1dd1335a43e365ea42d49aa27fd17c083423fdd5): ```diff - encoding = "ascii" if...