Omar Salman

Results 170 comments of Omar Salman

@jeremiedbb, @glemaitre Is there any part of this issue that is remaining and can be worked on or all of them are taken or complete?

> change in cdef class BinaryTree necessary to fix float32/float64 conversion in Isomap #15474 I see. It is mentioned above along with the issue https://github.com/scikit-learn/scikit-learn/issues/15474. Does that issue need to...

Hi @adrinjalali Can I work on this issue? Would it be reasonable to start working on LogisticRegressionCV?

> @OmarManzoor you can give it a try, but beware the work in this issue is very involved, I would probably recommend something less involved at this point for you,...

Hi @adrinjalali Can I work on ElasticNetCV, LassoCV and if required also MultiTaskElasticNetCV and MultiTaskLassoCV since all these inherit from LinearModelCV?

> That'd be really nice @OmarManzoor . I think with the refactor done in the GridSearchCV PR and the tests you had added, we should be able to test them...

Working on LarsCV and LassoLarsCV

Working on RidgeCV and RidgeClassifierCV.

@jjerphan Could you kindly check the error and let me know what I am missing? It is an error related to `ImportError: dynamic module does not define module export function...

> Hi Omar, thank you for looking into it. > > Adding support for float32 in binary trees is major work. > > I think we might want to proceed...