Nyan Helsing comments

Results 46 comments of


                                            Nyan Helsing

Checking for iter not valid way to check is iterable

Oh I wrote which object in that original comment - looks like it was a `SimpleLazyObject`. That fix isn't really ideal- makes a whole list. I'm trying to think of...

[SVCS-899] Remove cute trick to deal with buffer size

The test failing shouldn't matter because we're removing v0.

[SVCS-826] S3 Compatablilty

Yep that's true, its related to s3-compat. Replacing the calls with client library is because the signature stuff in boto2 is delusional. the signature stuff in boto3 works as intended....

[SVCS-528] [Blocked] Improve gdoc rendering - WB Part

I think some of the stuff here may be better passed as a query param that waterbutler passes through to gdrive transparently, this pr currently puts code that deals with...

[SVCS-294] Add rename validation

TODO: Double check this isn't supported, and clarify pr message a little bit.

[SVCS-132] Factor out move/copy code

Need to make it not a decorator

[SVCS-479] Raise exception for copy/move replace folder that orphans itself.

See previous PR for discussion https://github.com/CenterForOpenScience/waterbutler/pull/274

[SVCS-479] Raise exception for copy/move replace folder that orphans itself.

@cslzchen Can you note here what specifically blocks this PR that is resolved by #341?

[SVCS-137] stop passing query params as kwargs

Waiting on v0 removal. Waiting on update for all providers' signatures.

fix: Try to add a trailing newline if the file had one

Hi just wanna ping on this because there hasn't been any response on this yet and the bot marked wontfix; yet the problem isn't fixed.