Neal van Veen
Neal van Veen
So I was experimenting with a bunch of Typescript 4 features (including 4.1), and came up with the following proof of concept (that incidentally also goes for the same idea...
How is it normal to have to open the datepicker three times in a row? To change a date, to change the hour and to change the minute? This is...
Also confirming this issue. It causes a datepicker selection event to close the modal it's contained in.
This issue still seems to occur in 18.1.2, fyi.
It's because the constructor to DomPortalOutlet has changed in v20: https://github.com/swimlane/ngx-charts/blob/47a07d1805879f750111f0f32d44c8e8f3a22671/projects/swimlane/ngx-charts/src/lib/common/tooltip/injection.service.ts#L145 Ths constructor does not take a ComponentFactoryResolver anymore, since https://github.com/angular/components/commit/cda5c8e686b0c4394b382db08c2d0b4b793ac7d6
I was about to submit my own PR, but looks like https://github.com/swimlane/ngx-charts/pull/2049 was ahead of me.
> > I was about to submit my own PR, but looks like [#2049](https://github.com/swimlane/ngx-charts/pull/2049) was ahead of me. > > Happy to have your input or updates. This is my...