Eduard Voronkin

Results 25 comments of Eduard Voronkin

Hi Daan, I've tried latest dev3 and now observing another crash, but with different callstack and on NULL page: ``` Unhandled exception at 0x00007FF721024208 in App.exe: 0xC0000005: Access violation reading...

I can tell that `mi_page_t* page = _mi_ptr_page(p);` in `mi_heap_malloc_zero_aligned_at_overalloc` returned `NULL` page when `p=0x0000000003990080` and then we used it here: ``` if (aligned_p != p) { mi_page_set_has_aligned(page, true); ```

With `MI_DEBUG_FULL` this assertion fails: ``` mimalloc\include\mimalloc/internal.h":585, _mi_ptr_page assertion: "p==NULL || mi_is_in_heap_region(p)" ```

Hi @daanx , is the crash reported in https://github.com/microsoft/mimalloc/issues/1087#issuecomment-2878619915 also supposed to be fixed by https://github.com/microsoft/mimalloc/commit/4161152d17edbfb891733493310ea65278298f76? I seem to still be hitting it with the latest dev3 (`_mi_ptr_page` returns `nullptr`...

I've added more logs for page allocations / placing of pages in `_mi_page_map` and here is what I can tell: `mi_heap_malloc_zero_aligned_at_overalloc`: ``` mimalloc: ptr 0x04050080 allocated from page 0x04040000, size:...

OK, after debugging it for a while I think this line is wrong: ``` static mi_page_t** mi_page_map_ensure_at(size_t idx) { mi_page_t** sub = mi_page_map_ensure_committed(idx); if mi_unlikely(sub == NULL || idx ==...

Thanks @daanx - it works with the recent commit in dev3!

Hey @daanx - could you check this change once again, please? It makes some interposes more robust (so they are always present when available rather than excluded depending on target...

> Nowadays, one should link with the universal C runtime library which is a DLL There are multiple reasons why one would want to link CRT statically. 1. Security (harder...

@microsoft-github-policy-service agree company="Roblox"