Lavi Khandelwal comments

Results 8 comments of


                                            Lavi Khandelwal

Replace copier.Copy with optimized manual deep copy in URL.Clone (#2678)

@No-SilverBullet @FoghostCn I updated URL.Clone() in common/url.go to use defer for lock releases and added nil checks for params and attributes as per the suggestions. Additionally, I enhanced TestSubURLCopy to...

Replace copier.Copy with optimized manual deep copy in URL.Clone (#2678)

@No-SilverBullet Rebased `issue-2678` onto `upstream/develop` for CI sync. Benchmarks: 303 µs/op (avg of 5 runs), ~1.41x faster than `copier.Copy`. All `common/` tests pass locally (Windows & Ubuntu WSL, including `-race`),...

Replace copier.Copy with optimized manual deep copy in URL.Clone (#2678)

@No-SilverBullet even after fetching the latest changes , getting the same issue so should i try any other approach or recreate a new pull request with same changes ?

Replace copier.Copy with optimized manual deep copy in URL.Clone (#2678)

@No-SilverBullet @AlexStocks plz review this , i have changed it acc to your suggestions in this new pr and also fixed the cl error.

feat: add env-value-from as opt-in check for #705

@janisz have made the changes you suggested

feat: add env-value-from as opt-in check for #705

@janisz Thanks for the suggestions and pointing out some of my mistakes and I worked on them as suggested. I have added some new tests as follows: 1. ConfigMap failing...

[FEATURE_REQUEST] EnvVar ValueFrom checks

@janisz Is this feature still needed ? I'd like to work on it .

[FEATURE_REQUEST] EnvVar ValueFrom checks

I have implemented a draft solution in which i implemented the `env-value-from` check from #705, based on @josegomezr WIP branch. It flags non-existent secrets/ConfigMaps in `valueFrom` fields for `DeploymentLike` objects....