Adam Love

Results 48 comments of Adam Love

Okay, @raix I see some of the comments you've made in the past. It seems like we need to be able to generate the service worker and manifest.json. I see...

I added this file to it: https://github.com/Neobii/push/blob/v3.x/lib/client/browserPush.js and it's based off of https://developers.google.com/web/updates/2015/03/push-notifications-on-the-open-web?hl=en . So now, when you call Push.enable(true) and you are in the browser, it will prompt you...

I'm getting a little bit closer: https://github.com/Neobii/push , on push configure I'm adding the manifest and service worker which are in the package folder now.

What do you think I should use to generate the manifest and web service worker? I see `cfs:http-methods` and `WebApp.connectHandlers`. The manifest needs to have `gcm_sender_id` and we have that...

Hmm, are you loading in the service worker in an iframe there? I don't see where you define the service worker like `navigator.serviceWorker.register('/packages/raix_push/browser/service-worker.js')`. Are you doing it a different way?

Okay, I'm going to work on generating the manifest.json file from the config, check out this other package that seems to work: https://github.com/taromero/meteor-chrome-push-notifications/ I need a hint on tying the...

~~What do you think about moving the json file to the private folder and loading them in through Assets?~~ It looks like I can't load assets outside of the package,...

Okay! I got the browser manifest generating from the push configuration using the `push.configuration.js` plugin. https://github.com/Neobii/push/blob/v3.x/lib/server/push.api.js#L50 To add it to the body I simply did `$("body").append('');`, only if they are...

The more I think about it, it seems like we should split this into a couple different packages. - One package that connects push notification server and handles subscriptions -...

In services and api's for my app, I don't see GCM as something I can manage, only FCM.