Nenad Pantelić comments

Results 29 comments of


                                            Nenad Pantelić

Add query parameter to sort users for GET /users and GET /users/verified APIs

@isabelcosta Is this active and available?

Add query parameter to sort users for GET /users and GET /users/verified APIs

Sure @isabelcosta, I will take a look.

optimise code for repeated code in `app/api/dao/user.py` `get_user_dashboard`

@isabelcosta What's going on with this issue?

fixed race conditions in the signup page

Yes, in this case validators will solve the potential issue. I'm saying that we should protect the DAO layer, cause some DAO objects can be used in multiple controllers and...

Delete relation when the user did not create the request - throws wrong error message

@vj-codes Can I take it? :slightly_smiling_face:

Delete relation when the user did not create the request - throws wrong error message

Thanks @epicadk :slightly_smiling_face:

Updating an user with empty username and name should give an error message

HI @isabelcosta , @vj-codes :wave:. I would like to take on this?

Bugfix: Fix response message when user is not the creator of the mentorship request

@epicadk @vj-codes @devkapilbansal Can you please review this? Thanks :slightly_smiling_face:

Bugfix: Fix response message when user is not the creator of the mentorship request

> So it was just reordering the conditions. > > LGTM > Thanks @NenadPantelic for this. > > P.S. :- Maybe I found some similar happening in `tasks` or `task_comments`...

Bugfix: Fix response message when user is not the creator of the mentorship request

@isabelcosta There is already a test that tests this feature. But I can add test that will test the case when the mentorship relation is not in the pending state....