Alex comments

Results 528 comments of


                                            Alex

Update Ruff and Fix Linting

Let the test run, everything good so far except the pso module, but that hangs in main as well: ![image](https://github.com/user-attachments/assets/29dcd7cf-917e-47c5-a078-7903385e7e3a)

Fix issues with kerberos and non NTLM domains

> An issue with delegate also ? We didn't test it, but it likely would be. If you wouldn't have NTLM and delegation. Just added it to be sure

Fix issues with kerberos and non NTLM domains

Ah hmm maybe we should just change `self.args.kerberos` as well... For example laps login sets `self.args.kerberos` which would now break. Or we change the line in laps to `self.kerberos` EDIT:...

Fix issues with kerberos and non NTLM domains

Should be fixed now ![image](https://github.com/user-attachments/assets/8fe2914b-ce23-4512-93bd-d076a9aa9add)

Fix issues with kerberos and non NTLM domains

All working as intended: ![image](https://github.com/user-attachments/assets/b4c95f1d-b73d-4530-99ba-1e68f283741c)

Domain format in databases

Humm yeah the whole database functionality would probably need an overhaul...

Domain format in databases

Looking at @Marshall-Hallenbeck perhaps? 😁

Hitting maximum character limit while executing powershell string

Thanks for the bug report! We will take a look into it.

Option to save the kerberos tickets when doing RBCD

Thanks for the proposal! Maybe we could use the `--generate-tgt` arg to dump TGTs/STs in these cases

Add new SMB module to extract GPO deployed privilege assignments

Thanks for the PR! I will take a closer look at it when i have the time. What i quickly spotted is that it instantiates a new ldap connection. Do...