Alex
Alex
Thanks for the explaination! However, i think maintaining a patched version of an ldap library inside of NetExec is neither the right place, nor feasible to maintain in the future....
Hi, gonna close this for now. If you made progress feel free to just reopen it 👍
Can confirm at least for All-The-Mods 10 (1.21.1) it works 🎉
Not sure if that is due to this PR, but it crashed the server after ~5mins: ```log [16März2025 17:51:54.445] [Server thread/ERROR] [net.minecraft.util.thread.BlockableEventLoop/FATAL]: Error executing task on Chunk source main thread...
Highly appreaciated! This is also ancient stuff. Can you also rip out `on_response`/`on_request` in the example module and the smb.py module logic?
> Or another solution is to embrace bloodhound-ce and just use it and drop legacy bloodhound (i prefer this solution but the pr offer both choice in case) Honestly, i...
> sorry for keep updating this pr. i made some adjustments for better usage. No worries about that :) Thanks for the PR! I will take a look at it...
> I'll have to run `FURB` myself to see what changes it does, but from looking at it, it looks like its a good way to update old crappy code...
> If they're considered "unstable" yeah, probably not a good idea to use them. Path is the new way to use files with Python, so we should move to that....
We should probably use [PTH](https://docs.astral.sh/ruff/rules/#flake8-use-pathlib-pth) then as well. However, that would be a lot to do :D 