Alex

Results 528 comments of Alex

To "1.": - `subsubfolder3` might be skipped because it is empty? However imo when we download a folder i would expect to fully have its structure downloaded - `subsubfolder2` only...

> Yeah it doesn't download empty folders because... what's the point? I guess I can add that in if you think it's a good idea... What's the use of having...

> Okay, I can update it. Do you think doing something like displaying [EMPTY] when downloading it would be helpful? My concern is people downloading a big file structure that's...

> There is still something weird going on: ![image](https://private-user-images.githubusercontent.com/61382599/450686440-dc53f9fd-9a2a-4c90-9c68-3b12c1c37271.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDk1MDQ3MDEsIm5iZiI6MTc0OTUwNDQwMSwicGF0aCI6Ii82MTM4MjU5OS80NTA2ODY0NDAtZGM1M2Y5ZmQtOWEyYS00YzkwLTljNjgtM2IxMmMxYzM3MjcxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjA5VDIxMjY0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY3ZTk5ZGFlODE3YTI2NDI5ODhhMzE0ZWVjMjU2ZjIxYjljYWYxOTUxMzczZTY5MmRiODRmMmU0ZDI1MzA4MjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zTnSGqyvzlBrxMwBZ-HjzFbZ7Uzi7hDtXGqVKZUsRbk) > > 1. It doesn't download all folders in the folder Basically i don't want users to experience the same confusion...

@Marshall-Hallenbeck there is still the bug with the forward slashes and therefore adding the remote path to the local structure: Possibly missing path sanitation before creating the local folder structure?...

Maybe the 3rd option would even be the best as there won't be an AD with a disabled DC machine account, but there will definitely (or hopefully) ones with the...

I have changed stuff a bit: - name `sccmrecon`->`sccm-recon6` because that more accurately represents the technique: https://github.com/subat0mik/Misconfiguration-Manager/blob/main/attack-techniques/RECON/RECON-6/recon-6_description.md - Muted the output if we can't query the SMS, because this will...

> Hi! thx for the improvement, should the name be sccm_recon6? Honestly i am not a huuuge fan of underscores instead of the single dash, but if you prefer that...

@Mauriceter if the changes look good to you we are ready for merging