Alex

Results 528 comments of Alex

> > Would it be possible to detect a folder on a remote system? Than we could just integrate it into the existing get commands > > Well the current...

> just using the verbs "get" and "put" doesn't make it clear what you are getting or putting, so it's sorta confusing, and honestly, changing all that code to just...

> > I mean we are on SMB, imo its pretty clear what you are trying to achieve > > Well I disagree with that... we have numerous options to...

> > Also imo "recursive" download should always the default for folders, but that's just my opinion, thoughts? > > Yeah that makes sense, but how many levels recursive? My...

Somehow also subfolders of the specified folder were not downloaded. E.g. here the folders "Machine" and "User" are missing ![image](https://github.com/user-attachments/assets/3bf16e2f-293a-4abb-9b12-bb910bfa3c23)

> @NeffIsBack ugh I'm stupid, I literally just had two args switched. Pushing a commit now with that fix plus more debugging for the future. Happens 😄 gonna test next...

> > > My intuition would always be, that --get-folder would get the folder and all its contents. So i guess indefinitely (until the OS rejects files because of no...

There is still something weird going on: ![image](https://github.com/user-attachments/assets/dc53f9fd-9a2a-4c90-9c68-3b12c1c37271) 1. It doesn't download all folders in the folder 2. I still have the path i specified in the folder structure

Looks like "2." is due to the specification of the path with forward slashes, but as impacket/nxc accepts it we should probably just escape/normalize them before creating the download path:...