Benedict Pak comments

Results 11 comments of


                                            Benedict Pak

DeviceController audio memory leak

Hi @ldai1 , No audio device was selected. Here is another example, I opened the meetingReadinessChecker app and replaced it with the following code: ``` import { DefaultDeviceController, ConsoleLogger, LogLevel...

DeviceController audio memory leak

Hi @richnew10, yes a GC was forced, but the object persists in memory.

Camera and microphone do not switch off after disabling permissions or disconnect device

Hi @michhyun1 , thanks for the suggestion. I didn't use the permissions API as it's still a work-in-progress, but as a workaround, I am attaching a device change observer for...

Slider crashes entire page on large min/max values

Hi @williamernest , these values are not used but resulted in a crash that was difficult to debug as values were being initialised to Infinity for an audio duration slider....

fix: monitor objects and delete property

@mcollina Do you mean that `sessionProxyCache` should be moved into the scope of `fastifySecureSession`? I was not aware that `fastifySecureSession` would be called multiple times. Edit: I've moved its scope.

SSR rendering throws Internal error: ReferenceError: navigator is not defined

Fixed in #286

OrdConnectKit prop to hide rendered buttons

Fixed in #285

Closing wallet pop-up not caught for Leather

This issue has been fixed by Leather.

SSR rendering throws ReferenceError: localStorage is not defined

Fixed in #289

Video is showing locally for participant 2, but cannot be seen by participant 1, and participant 1 video disappears later

Hi, was anyone able to check this issue?