NamanParlecha

Results 16 comments of NamanParlecha

Hey @perebaj @bwplotka!! I have added in the test cases and refactored some part that were mentioned in #17166 can i get a round of review on this PR?? This...

Thanks for catching those!!! I missed changing logs in float type Appender

Hey @krajorama @bwplotka @perebaj, I have refactored the test a little bit in [0c8099f](https://github.com/prometheus/prometheus/pull/17205/commits/0c8099f100a671fd109e207716d9da92b6d005d3) Since in the previous pr #17166, we were already testing conversion of histogram so removed those...

Hey @krajorama would it be possible for you to review the follow up PR for #17166, open from a long time??

> Don't have a strong opinion on having or not having this functionality. I still open the `Makefile` in most cases. The changes to the prometheus-mixin look fine. It will...

@bwplotka refactored, have a look and let me know if any changes are required

Hey @bwplotka @bboreham, I have refactored the code abit, I have removed the `help` from `Makefile.common` and will no longer be including `Makefile.common` in any sub `Makefile` (eg /documentation/examples/Makefile) -...

Hey @jesusvazquez could you take a look at this, and suggest any changes if required?

@HawkingRadiation42 Yep i was working on it will push it this weekend

> Is it possible to add a feature where block reloads by invoking some functions. thinking in terms of event driven architecture. This is a work around for optimizing the...