Ignacio Palacios

Results 45 issues of Ignacio Palacios

This PR is a first iteration for aligning Rococo and Kusama as part of: https://github.com/paritytech/delivery-services/issues/154 Rococo runtime has been modified trying to follow line by line Kusama runtime. All differences...

A0-pleasereview
B0-silent
C1-low 📌
D5-nicetohaveaudit ⚠️

Right now, `pallet-xcm` does not provide a method to to send back KSM/DOTs that where previously reserve transferred from Relay to Parachain. `reserve_transfer_assets` is meant to be used by the...

T6-XCM

We recommend you to run ``` cargo +nightly fmt --all -- --check ```

The use of off-chain worker for fetching the storage price should improved taking into consideration how they work and when they are executed. Some context about things to pay attention...

I noticed that you are using `Twox64Concat` by default for all your StorageMap keys. Be aware of the potential issues of choosing the incorrect hasher. From: https://docs.substrate.io/v3/advanced/cryptography/#xxhash > Because xxHash...

Avoid panics at almost any cost and add "proofs" for expect() calls on why they cannot fail. The only reason to panic should be in case a block should not...

https://github.com/CESSProject/sbp-code-docs/blob/main/m1/cess-dscm.md Your off-chain worker is not signing transactions anymore, it is using unsigned transactions instead.

Improve benchmarks for `file-bank` and replace the fixed weights

It is a good practice to give indexes to your runtime pallets. More info here: https://substrate.stackexchange.com/questions/1163/whats-the-logic-behind-polkadots-choice-in-pallet-indexing

- [x] `UnitPrice` value should be able to be set from genesis or have a default value. If for some reason OCW http request fails, `UnitPrice` would default to 0....