Nick Laws

Results 32 comments of Nick Laws

trying to close and reopen to kick off Actions tests

@joaquimg I tried to get the tests running on actions by updating the testing framework to use test/Project.toml but it is still expecting the old format: ``` ERROR: Compat `Cbc`...

@joaquimg I am finding that for very large problems any loops over all variables or constraints takes a large amount of time. For example, the [build_bounds!](https://github.com/joaquimg/BilevelJuMP.jl/blob/059543614d1e8b6f59f285adeeb3ba8a43697242/src/jump.jl#L645) method loops over all...

@joaquimg Can you please review this next chance you get? (The paper has been accepted to IEEE Transactions on Power Systems and will be published soon!)

Thank you @joaquimg! I will respond to your comments that I have answers for now; and I will work on MWEs/more tests soon.

@joaquimg FYI I am working on more tests for the new capability

@joaquimg how does this codecov thing work? I added an explicit test for one of my new functions https://github.com/joaquimg/BilevelJuMP.jl/pull/157/commits/d1e893e828bee3719a90770c85afd5f1edb9b2e1 but the [codecov still shows that this code is untested]( https://app.codecov.io/gh/joaquimg/BilevelJuMP.jl/compare/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr%20comments&utm_term=Joaquim%20Dias%20Garcia#D4L761)?

@joaquimg any idea why non-linear tests would start failing? ```julia Bilevel Conic JuMP NLP: Test Failed at /Users/nlaws/Projects/BilevelJuMP.jl/test/jump.jl:2548 Expression: ≈(objective_value(model), 12, atol = 0.1) Evaluated: 0.0 ≈ 12 (atol=0.1) Bilevel...

@joaquimg I'm not sure what else I can do about the codecov. From what I can tell it is now dinging me for coverage reductions for lines that I did...

@joaquimg I think that we are good with test coverage of my contributions: ~400 out of ~1600 of the new lines are tests and src/bilinear_linearization.jl has ~95% coverage. Please let...