n8programs

Results 34 comments of n8programs

I have conducted some tests with Lambert vs. Phong on a modern M1 Macbook Pro. Not exactly a low-end mobile gpu, but still good for testing performance. The benchmark was...

> Sorry, but such a simple scene on such a powerful device is not a viable test case. This needs to be primarily tested with low and mid-range smart phones...

I literally shouted with joy when I first read this PR. Insane work.

Sorry about that! Still very new to the whole pull-requesting thing 😓

All right the files are no longer being overwritten! How would you recommend I refactor things? I would be against a `RectLight` - One, because there's already `RectAreaLight`, and two,...

> Are we against calling this something like "ProjectorLight", then, if a SpotLight modification isn't acceptable? I agree that "RectLight" is a bit confusing. I think ProjectorLight would make the...

> > As I said before, I'm not sure the additional code complexity warranted by a ProjectorLight would be worth it - given how simple the modifications to the SpotLight...

> How do you feel about using one of these existing equirect maps for the environment that are already uploaded to my '3d-demo-data' repo? > > `https://raw.githubusercontent.com/mrdoob/three.js/dev/examples/textures/equirectangular/royal_esplanade_1k.hdr` ![image](https://user-images.githubusercontent.com/734200/190034256-3db71b40-e364-43fc-b702-9ffbeebe9918.png) > >...

> @N8python when you have a chance can you update this with some of the new diamond shader code including fresnel and dispersion - and then I can clean up...

Added chromatic aberration - one concern is that there is a form of mipmap aliasing caused by the Equirect environment that I'm not sure how to fix - it doesn't...