Arthur Outhenin-Chalandre
Arthur Outhenin-Chalandre
Hello any news on this PR :) ?
Hmmm this is not super convenient since we won't be able to run those locally anymore (at least less easily). From what I can read tox seems to pass the...
> @MrFreezeex hi Arthur, i think we always need to pass the JSONNET directory to tox in one way or another. so unless we hardwire a default directory in tox.ini,...
> the thing is, again, in CMake `ENVIRONMENT` represents a set of env vars, see > > https://github.com/ceph/ceph/blob/e3d4c7707e26ee0f573d9972cf617d9e9ccc0ac9/cmake/modules/AddCephTest.cmake#L93-L102 > we should not override it with a single `PATH`. Ohhh ok...
> @MrFreezeex i updated the commit message to reflect the problem in last change. For the jsonnetfmt issue I think we can go ahead with https://github.com/ceph/ceph/pull/47633 as it's ready/approved and...
Are you trying to fix the case where a cluster that is being imported in Terraform? Because if that's the case it would still want to recreate the cluster after...
Hmm on our OpenStack cluster changing the number of nodes was working fine (IIRC our magnum is running train version). Maybe magnum changed something in the API...
I am guessing that if this is the right fix, it would also applies to {min,max}_node_count on the nodegroup resource as well.
Hiii @maciej-markowski, wow thanks for this big PR. It mostly looks good but could you separate this into two PR, like the role renaming in something separate from the rest?...
/ok-to-test