Agatha Bahati
Agatha Bahati
@MaksymMalicki the tests are failing due to a circular import issue emanating from the hinter package that the `secp_utils.go` relies on. I'm guessing the easiest solution would be to decouple...
> Hi @MoigeMatino, thank you for the contribution. I understand the problem and agree, that this functionality needs to be decoupled. However I don't think that creating a separate utility...
> @MoigeMatino I agree with @MaksymMalicki on the second approach. Functionalities such as `GetConsecutiveValues`, `WriteToNthStructField` and `WriteUint256ToAddress` should not go in the `operand.go` file. The `memory` package seems like a...
@cicr99 @MaksymMalicki I think creating a separate PR for moving `GetConsecutiveValues`, `WriteToNthStructField `and `WriteUint256ToAddress` to `memory.go` would be ideal, I've noted that it needs a number of changes on multiple...
> Sure thing @MoigeMatino, let us know when the new PR is ready! Good luck! Will do, thanks @MaksymMalicki
> @MoigeMatino I've added the label `blocked` to this draft until the problem with the dependencies is solved. I've also created a separate issue for it #384. Are you currently...
> @MoigeMatino that's great! Could you comment on the issue #384 so we can assign you to it? @cicr99 Done. Apologies that #384 has taken a while, closing on this...
> @MoigeMatino any update? @TAdev0 resolving a couple of issues, should be done soon. Will reach out in case of anything.
@TAdev0 This PR is now ready for review.
> @MoigeMatino just saw your last commit. You still don't use the newly created helper function. Do you need any help? you need to remove the comments you added as...