TJ Yin

icon indicating an email [email protected]

icon company @facebook icon location Menlo Park, CA

Results 4 comments of TJ Yin

building fails with folly

Thanks for reporting this. It's a known issue that we are actively investigating. It's mentioned in another project as well: https://github.com/facebook/openr/issues/100

Installs an empty directory include/fb303/test

This is known CMake issue https://gitlab.kitware.com/cmake/cmake/-/issues/17122 We could exclude these directories explicitly, though I don't feel it's worth to complicate the build script.

Didn't detect new file correctly

Your patch works for me. Thanks!

Installs empty directories under include/

This is known CMake issue https://gitlab.kitware.com/cmake/cmake/-/issues/17122 We could exclude these directories explicitly, though I don't feel it's worth to complicate the build script.