MithrilMan

Project status

7

Hello @davidfowl It's not clear to me the future about this project, is it still going on or is abandoned? Are you planning to port this to .NET 5? I...

code style & editorconfig

1

@davidfowl the project has an editorconfig https://github.com/davidfowl/BedrockFramework/blob/master/.editorconfig , I think should be used to enforce some rules. e.g. this is mine that enforce a specific use of braces, spaces, formatting...

### Describe the bug The setting `AllowPackageOverwrites` ignore .snupkg . If you set `AllowPackageOverwrites` to `false`, updated packages on source symbols (.snupckg) are overwritten. ### To Reproduce Steps to reproduce...

I'm working on pushing dotnet core to the limit in terms of performance and memory allocation, and I'mopening issues on NBitcoin when I find something interesting that can be improved,...

ILoggerFactory cannot be used to instantiate Logger classes different than PrefixLogger

2

A note about ILoggerFactory Actually the implementation is flawled because we can't change the type of log class we are using note that ILoggerFactory is defined into Microsoft.Extensions.Logging.Abstractions so we...

For debug purpose, would be very helpful to have a command argument that let you rewind the node, during startup, at a specific height, like `-rewindto=HEIGHT`

[BlockStore] ProvenBlockHeaderStore location

1

IProvenBlockHeaderStore, ProvenBlockHeaderStore, ProvenBlockHeaderRepository and similar class are actually into Startis.Bitcoin.Features.Consensus. I think that concrete classes should be placed into `Stratis.Bitcoin.Features.BlockStore` and interfaces should be declared into `Stratis.Bitcoin` project, like `IBlockStore`...

IBitcoinSerializable used for both Network and DB serialization

2

Actually we are using IBitcoinSerializable for both Network and DB serialization. I think we should have two different interface to serialize to different medias because we may want to optimize...

I see there is a method in NetworkPeerFactory https://github.com/stratisproject/StratisBitcoinFullNode/blob/4c1685abfb7e0b4f486b486fa4189f76034cedaf/src/Stratis.Bitcoin/P2P/Peer/NetworkPeerFactory.cs#L162-L181 that's only used by one Test https://github.com/stratisproject/StratisBitcoinFullNode/blob/4c1685abfb7e0b4f486b486fa4189f76034cedaf/src/Stratis.Bitcoin.IntegrationTests.Common/EnvironmentMockUpHelpers/CoreNode.cs#L232 I think it's not a good practice to have implementations just for test needs....

We must be careful when implementing a Dispose() method or when we need to dispose inner disposable objects, because if we don't handle a potential throw, we may end up...