Mitchell Goodwin

Results 100 comments of Mitchell Goodwin

This code is covered by a golden test. The golden test isn't failing because it's fuzzy matching to the image from before https://github.com/flutter/flutter/pull/137275.

> Shouldn't we be marking old tests as wrong once we decide we're changing the behaviour? cc @Piinks I asked @Piinks that question and the answer was that the incorrect...

> In this patch I don't use anymore the transparency (because of route transition issues and unwanted blurring effects), and rely instead of the CupertinoTheme.of(context).scaffoldColor to make the bar appear...

Then if the bottom tab bar does it as well, we would want that in the Cupertino widget as well. If you're willing to include it in your PR, that'd...

Hi @toda-bps. Thank you for taking the time to put this PR together. Looks like there's some test failures in `packages/flutter/test/cupertino/route_test.dart` and `packages/flutter/test/material/page_test.dart`.

You can find logs by selecting "Details" next to a failed check -> then "View more details on flutter-dashboard" near the bottom -> then looking under Steps and Logs. Usually...

> I tried to fix the test failure, but realized that it was difficult to improve the swipeback behavior while preserving the existing behavior using the previous methods. > >...

> @MitchellGoodwin do you think this would be fixed by the font proposal you have? It's possible that it might be related, but my instinct is that this is a...

Still in the progress of looking into this, but the issue is that Apple removed the ability to look up system fonts by name, so dot prefixed names like '.SF...

Keeping this open for now. [flutter/engine#46857](https://github.com/flutter/engine/pull/46857) allows for opting in to correctly using the system fonts in a way that's unlikely to get broken by changes made to Apple APIs....