Mitch Razga

Results 14 comments of Mitch Razga

I'm also experiencing this issue. Edit: Unmanaged types seem to be serializing and deserializing with Native AOT correctly.

Thanks @timyhac! I was initially just sharing some rough thoughts in that PR but great to see that you are open to this! Your benchmark matches my expectations, since the...

> Something that I'm unsure about is how to expose these overloads in `libplctag.NativeImport`. My understanding is that it is a C# taboo to have `unsafe` methods that are public....

Haven't forgotten about this, just been extremely busy sorry. You raised a really good point about how consumers on older frameworks would have to take a dependency on ```System.Memory```. A...

> @MitchRazga please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. > > ``` > @dotnet-policy-service agree [company="{your company}"] >...

@pakrym Is this complete but just not published? Played around with this branch earlier and ```Func``` resolution seemed to work as expected. Tests were passing too.

Did run into one issue when multiple constructors use implicit funcs it will always choose the first one defined even if the service is not registered/optional. eg. ```c# using Jab;...

Other than the multiple constructor issue mentioned above, it seemed pretty good as is. I tried [step-through debugging the source generator](https://github.com/JoanComasFdz/dotnet-how-to-debug-source-generator-vs2022) but still didn't have enough understanding to be able...

Looks like in [```SelectConstructor```](https://github.com/pakrym/jab/blob/587703be9de3357e4b88b0db1d682e1b48f037c0/src/Jab/ServiceProviderBuilder.cs#L814) that [```CanSatisfy```](https://github.com/pakrym/jab/blob/587703be9de3357e4b88b0db1d682e1b48f037c0/src/Jab/ServiceProviderBuilder.cs#L757) always returns false for ```Func``` and will therefore fallback to the first/shortest constructor. https://github.com/pakrym/jab/blob/587703be9de3357e4b88b0db1d682e1b48f037c0/src/Jab/ServiceProviderBuilder.cs#L801-L807 https://github.com/pakrym/jab/blob/587703be9de3357e4b88b0db1d682e1b48f037c0/src/Jab/ServiceProviderBuilder.cs#L830-L831 Might need to something [here](https://github.com/pakrym/jab/blob/587703be9de3357e4b88b0db1d682e1b48f037c0/src/Jab/ServiceProviderBuilder.cs#L765) to first extract the...

Thanks @JasonBock The `Validate()` method sounds good but I would be concerned with how opinionated it could be. Ideally it would only validate usage of Rocks and not improper code...