Max

Results 168 comments of Max

@mikefarah yes, that worked. Thanks a lot for hint 👍 Since the bug is still prevailing I would leave this issue open until it is fixed in [go-yaml/yaml](https://github.com/go-yaml/yaml). Do you...

I filed an issue. Let's see what happens: https://github.com/go-yaml/yaml/issues/801

> Would it make more sense to clear out the claim's resourceRef so that it can create a new XR name in this scenario? Not really, because the newly generated...

> I think I'm missing something here. Could you maybe elaborate on the problem/use case touched on in https://github.com/crossplane/crossplane/issues/3286 a little more? It's seeming like there's a case where [...]...

> I'm on the fence about this change. @MisterMX how frequently do you see it happening? I have encountered this once where the composite was deleted in an unknown way...

We are also interested in this feature. We want to provision provider secrets using [kubernetes-sigs/secrets-store-csi-driver](https://github.com/kubernetes-sigs/secrets-store-csi-driver) which currently requires a volume mount to trigger the secret creation (https://github.com/kubernetes-sigs/secrets-store-csi-driver/issues/298).

I personally tend towards option 2 because internally, a CompositionRevision is converted to a Composition using the hand-written [`AsComposition`](https://github.com/crossplane/crossplane/blob/7a8f3e03abfb7d86e350a253466259fc7d1c7672/internal/controller/apiextensions/composite/revision.go#L29) converter function. By importing the same types we can just return...

> I wouldn't normally be a fan of sharing the same structs across API types due to the strong coupling of APIs. That is, if we ever did want to...

@negz one thought that caught me during the weekend was the design of CompositionRevisions in general. What if there are breaking changes in the Composition API in the future? How...