MisterAwesome23
MisterAwesome23
Aaaaaaaa! I did it. My first PR accepted and the message saying "You did it. You are an open source developer now" is AN ABSOLUTE BLISS! Thank you so much...
Just one question, while contributing to real projects the only difference is in the last step that is creating the pull request across the forks, instead of changing the first...
Hey :) I would love to contribute to the documentation for perspective. Is the issue still up (and no one is already on it already) can I take this up?
I would like to fix this bug. Is someone on it or may I start?
Thanks for quick reply. I will get going. I am pretty new to this and hope I'll seek help :)
Sorry for late response. Actually I got up caught setting the docker container its up running now :) I'm still catching up with the codebase and want to test this...
   Was an infinite loop expected here? Because I did not. Or is the bug for something else?
Should the calculated latency be reduced in the existing returned time or do we need a separate more accurate function?
Hey there :) Thanks for the issue. Just a suggestion- try previewing the comment in markdown since your issue could be made more readable by having proper markdown for code....
In NTPClient.cpp the following snippet- ``` int NTPClient::getHours() const { return ((this->getEpochTime() % 86400L) / 3600); } ``` Should ideally be able to return 23 as well. Eg: for EPOCH...