CoreMods icon indicating copy to clipboard operation
CoreMods copied to clipboard

CoreMods

Results 11 CoreMods issues
Sort by recently updated
recently updated
newest added

In javascript it will create LDC with a double value, which I have to add D2F after it. Maybe add a method in ASMAPI which will return a LdcInsnNode containing...

Discussed this a bit on stream before, so I'm making an issue to figure out the approach. I generate a log with all instructions of the transformed method when the...

`ClassNode` is not on the allowed class list, so using `Java.type('org.objectweb.asm.tree.ClassNode')` crashes. However `ClassNode` is required to use the `CLASS` target.

The method `ASMAPI#findFirstInstructionBefore` ignores the startIndex parameter and instead always starts searching from the end of the method. https://github.com/MinecraftForge/CoreMods/blob/c21a551966ef013dbda2b75aefcb15ecc7e814cd/src/main/java/net/minecraftforge/coremod/api/ASMAPI.java#L105 `Math.max` should be replaced with `Math.min` to fix this.

There currently doesn't seem to be a way to check the type of a LDC, since using cst.getClass().getName() is not allowed. In the debug environment I was able to get...

Somewhat related to #10, an [`INameMappingService`](https://github.com/cpw/modlauncher/blob/master/src/main/java/cpw/mods/modlauncher/api/INameMappingService.java) can map class names just like it can do methods and fields but there's nothing exposed in the coremod API to be able to...

This needs the ability to read the final transformed state of the class the wrapper is being generated for

This is actually a Nashorn bug, but I'd like to workaround it in CoreMods 5.3. Essentially, large arrays (either created with `[]` or with varargs) are not converted to the...

ASMAPI has various helper methods that are meant to make traversing through bytecode easier. Unfortunately while working on CoreMods 5.2, I made an oversight where invoke dynamic expressions cannot be...

This will allow some minor intellisense for coremod development.

enhancement