CoreMods icon indicating copy to clipboard operation
CoreMods copied to clipboard

ASMAPI#findFirstInstructionBefore ignores startIndex parameter

Open Meldexun opened this issue 4 years ago • 0 comments

The method ASMAPI#findFirstInstructionBefore ignores the startIndex parameter and instead always starts searching from the end of the method. https://github.com/MinecraftForge/CoreMods/blob/c21a551966ef013dbda2b75aefcb15ecc7e814cd/src/main/java/net/minecraftforge/coremod/api/ASMAPI.java#L105 Math.max should be replaced with Math.min to fix this.

Meldexun avatar May 23 '21 00:05 Meldexun