Mike Weller comments

Results 16 comments of


                                            Mike Weller

Fixes warnings when compiling with -Wconversion and -pedantic etc.

Yeah I didn't really expect this to get merged into the official repo. I can understand it takes a while to review all this and for most people it is...

Stream-based alternative to `testing::PrintToString`

Note: I would be interested in working on this myself assuming there is agreement on this being useful.

Stream-based alternative to `testing::PrintToString`

> Maybe I'm missing something, but why not just write an ostream operator

Ability to pass custom type to `WithParamInterface` and use with `testing::Combine`

Note: I would be interested in working on this myself assuming there is agreement on this being useful.

Ability to pass custom type to `WithParamInterface` and use with `testing::Combine`

@BMBurstein this looks great, though I think the `testing::ConvertGenerator` in your example should instead just be `testing::ConvertGenerator(` which should match the tuple constructor during conversion.

Ability to pass custom type to `WithParamInterface` and use with `testing::Combine`

> This was merged in #3967 Awesome!

MQTT Over WebSockets

I notice this issue is tagged "Shipping 1.1.0". Is this actively being worked on and is it likely to come soon? If not, would you be willing to work with...

SRProxyConnect Crash

The SRProxyConnect class is rather unsafe around NSStream lifetime and event dispatches. There have been similar issues in the past with SRWebSocket but those fixed haven't made it to SRProxyConnect....

SRProxyConnect Crash

Pasting some raw notes from a crash analysis I did: > SRProxyConnect crashes > > Two main variants of the crash we see: > > BUS_ADRALN at 0xffffffff89abcdef we're trying...

SRProxyConnect Crash

To further clarify what I think is happening: * An error occurs on the input stream * That error is processed on the SR_networkRunLoop via `failWithError` and we end up...