Micky

Results 286 comments of Micky

I somewhat like this new flag, but the fact that it requires so much text to be explained properly concerns me and makes me question its simplicity. > "Auto-bind the...

This PR does not supersede #64155. In that PR the code was harmonised and polished. One thing at the time. It doesn't quite supersede #65148 either because the implementation is...

I would like this but I am mostly concerned about implementation. The PR introduced many things at once and it's hard to grasp a focus on how the individual frame...

It's very hard to make out whether or not all changes are good. Not saying there aren't, but there's a... _lot_ to unpack in this PR. There's even API changes...

It's ok if you talk it out to the community with a Proposal, instead.

This compiles locally but it doesn't in the checks...

> I assume because you're including an editor header file from outside of the editor folder. So when making a `tools=no` build, the editor folder is not included in the...

Hastily attempting to address it so that this can be tested as soon as possible.

> It's great that it finds matches that use the same letters in the same order. But the algorithm should definitely prioritize a full substring match (`tree` is found as-is...

@RedMser I have updated the calculation. There's a large penalty the further away the `base`'s characters are from each other: ![GetTree](https://user-images.githubusercontent.com/66727710/189590968-cd5cd6cd-16eb-4dff-9963-a46d25b0e0e9.png) The score actually goes below 0.0, which *shouldn't* be...