MelReyCG
MelReyCG
I'm not sure what you're talking about, I don't think I did that myself, I just assigned myself to this issue because I will start working on it soon.
Yes I did, we moved it. I just filled the fields.
@paveltomin Timestep cuts were tested by the `checkMultiPhaseFluxStatistics` test (this simulation has 3 sub-timesteps). I added a guard (`testInputs.requireSubTimeStep`) so it will keep being tested with timesteps. About `useMass`, the...
@paveltomin I've added the CSV export and try to make the code of `SourceFluxStatsAggregator::WrappedStats::gatherTimeStepStats()` clearer. Do you think this method is missing something about timestep cuts? Or do you think...
@paveltomin > I just mean that one could potentially do the same mistake in the main code and in the test code, so unit test may not help catching it...
Ok I will add one or more `SourceFluxStatistics` in the exemples. `useMass` has indeed an influence on the `SourceFlux` units 👍 : - I fixed the `SourceFluxStatistics` and added a...
Ok I see. Thanks a lot for your inputs and review !
So, if I iterate on my branch, the version number will not change. To improve this version number, I think we should add a `build part` ([As semver seems to...
We should also keep [this issue](https://github.com/GEOS-DEV/GEOS/issues/2795) in mind.
I re-run the tests I made for this EPIC, and this point is not solved yet (the error is still the same). I'll submit a last PR to solve it,...