MeherRushi
MeherRushi
I'll look into the changes requested and update it soon, I'll also add test cases for the same.
Hey @lmb Thanks for the code review. I have added the test cases as requested. I also mentioned the reasoning behind my code. Please have a look once
Thank you for pointing it out @tklauser . I'll do the necessary soon
Hey @tklauser, I have formatted the code using `gofmt` Please do take a look when possible
> @MeherRushi It seems there are still some issues reported by golangci-lint: https://github.com/cilium/cilium/actions/runs/8015579723/job/21900979066?pr=30699 Could you please fix these as well? yes will look into it Sorry for the issues caused...
@danehans . Thanks for pointing it out. Extremely sorry for commiting such silly mistakes. Will make the changes soon.
@danehans I have made the requested changes. Please have a look once
Thanks for the guidance and help @tklauser @lmb @danehans @optix2000
@mauriciovasquezbernal Thanks for the review. Will make the required changes soon
@mauriciovasquezbernal , Yes there seems to be an issue trying to run gadgets using kubectl gadget on my end. I had tested it for the ig tool and it works....