Mauro Toscano
Mauro Toscano
Serialization doesn't need to be defined for the curve. You serialize the points of the curve, not the curve, and it's defined elsewhere. Also, add some tests with specifics points...
For some reason it's not compiling locally. failed to select a version for `rayon`. ... required by package `icicle-core v1.4.0 (https://github.com/ingonyama-zk/icicle.git?tag=v1.4.0#15a63cc5)` ... which satisfies git dependency `icicle-core` of package `lambdaworks-math...
I don't think the first optimization is right. The early return adds an additional branch, so it may make the average case slower, and we usually don't care about optimizing...
This must has been a change in the Cairo VM. I'll raise the issue to the VM team, and we'll pin the version here to use until it gets fixed.
I have updated the docs here, until we get it fixed: https://github.com/lambdaclass/lambdaworks/pull/809
Can you try with ? ```cargo run simple.cairo --trace_file simple.trace --memory_file simple.memory --proof_mode --layout small``` There seems to be an issue of the VM not activating the output builtin correctly...
Bits operations in field elements is a bad idea. In the base type it's ok, if you want to use it you should use the raw data of the base...
I see now that we have the to bits_le, we should probably remove both in the future, in the meanwhile we can add it
Our cuda implementation is being removed